Page MenuHomePhabricator

[Cashtab] Remove classNames from Tx.js
AbandonedPublic

Authored by kieran709 on May 25 2022, 17:55.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Replaced components with classnames with styled-components, removed unecessary 'antd-collapse' className. Related to T2445.

Test Plan

cd web/cashtab && npm start
Ensure there is at least one received eCash tx, eToken tx and genesis tx.
check that the Tx amount for each is the appropriate color

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-classNames-from-tx-js
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19157
Build 38062: Build Diffcashtab-tests
Build 38061: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/cashtab/src/components/Home/Tx.js
242 ↗(On Diff #33694)

Why the !important; ?

Will the colors not work without it? Was not required before.

This revision now requires changes to proceed.May 25 2022, 18:40
web/cashtab/src/components/Home/Tx.js
242 ↗(On Diff #33694)

It was not required before when using classNames, but with this method, since the new styled-components are variants of TokenTxAmt, I needed to use !important to override the color for the variants. I did it this way to maintain the existing TokenTxAmt, but I can try out some other options if you want to avoid using the !important property

I'm also getting a phab error trying to arc patch this:

This diff is against commit 1a40b338ccdafa164ed2599ab3450d577097f4c8, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (ba8c21de10830df27fae74c74bc3b0c944cf3e86)
    [Y/n]

Try abandoning this and putting it up against the latest master.

Try abandoning this and putting it up against the latest master.

You shouldn't need to abandon, you can just rebase the commit on master, and do arc diff

I get the same error here

 INFO  Base commit is not in local repository; trying to fetch.
Branch name arcpatch-D11521 already exists; trying a new name.
Created and checked out branch arcpatch-D11521_1.


    This diff is against commit ac2e681463206c86948f06c3044ff00ac9422dd0, but
    the commit is nowhere in the working copy. Try to apply it against the
    current working copy state? (21f9b245f1e7ad4d9e33ee806a28729d34333dd6)
    [Y/n]

What's your output for git reflog? Can you confirm this diff is on one commit?

@Mengerian are you able to arc patch this diff?

This revision now requires changes to proceed.May 26 2022, 23:00