Page MenuHomePhabricator

[Cashtab] [Chronik Websocket Notifications] [Part 2] Get Hash160s from wallet
ClosedPublic

Authored by bytesofman on May 27 2022, 23:46.

Details

Summary

T2447

Depends on D11530

Helper function getHashArrayFromWallet(wallet) and unit tests. Gets hash160s from active wallet. These are required for chronik websocket, which subscribes to hash160 and not addresses.

If wallet does not have hash160s (unmigrated), function returns false. In this edge case (as with websocket failures), the app will use alternate notifications.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested changes to this revision.May 28 2022, 01:50
emack added a subscriber: emack.

Getting the following upon arc patch D11531:

image.png (82×695 px, 18 KB)

Did you clone D11530 and then pushed this change on top as a new diff? If so I've seen this happen in these cloning scenarios.

This revision now requires changes to proceed.May 28 2022, 01:50

Getting the following upon arc patch D11531:

image.png (82×695 px, 18 KB)

Did you clone D11530 and then pushed this change on top as a new diff? If so I've seen this happen in these cloning scenarios.

Dang.

No, I followed this procedure in putting these together: https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6

However, it doesn't mention anything about ability / inability of other users to arc patch different branches.

Maybe I need to land the first part before this one can be reviewed?

It's also possible I messed it all up by accidentally running arc diff instead of arc diff HEAD^ when I first pushed up part 8.

Since Part 1 is mostly harmless, it's probably worth landing (when approved / ready) to see if rebasing to the latest master per the above instructions allows arc patch of the later diffs.

Anyway here's the plan.

1. Are you able to arc patch this diff if you run arc patch D11531 on top of the branch from D11530?
2. If no, I will make a 2 part stacked diff where I know I did not make the arc diff vs arc diff HEAD^ error and we will see if the second part can be arc patched
3. If no, then I guess stacked diffs can only be pulled down one at a time, or at any rate I am missing some step that allows them to be arc patched separately, so we will need to go green and land the diffs one by one.

UPDATE

I was forgetting to include "Depends on D11530" in the summary of the diff. You should be able to arc patch this now, though you may have to y through the error msg.

Let me know if it's still an issue.

arc patch works after stepping through that error msg. Diff content came through all ok. Just update the 4 snapshots prior to landing.

This revision is now accepted and ready to land.May 31 2022, 23:39