Page MenuHomePhabricator
Differential D11536

[Cashtab] [Chronik Websocket Notifications] [Part 5] Parse XEC txs from websocket msg
ClosedPublic
Actions

Authored by bytesofman on May 30 2022, 17:51.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC41d1bebc4393: [Cashtab] [Chronik Websocket Notifications] [Part 5] Parse XEC txs from…
Summary

T2447

Depends on D11535

Test Plan

Review new function, parseChronikTx
npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.May 30 2022, 17:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2022, 17:51
bytesofman requested review of this revision.May 30 2022, 17:51
Harbormaster completed remote builds in B19183: Diff 33726.May 30 2022, 17:53
bytesofman edited the summary of this revision. (Show Details)May 31 2022, 17:51
bytesofman added a parent revision: D11535: [Cashtab] [Chronik Websocket Notifications] [Part 4] Unsubscribe to Hash160s when active wallet changes.
bytesofman mentioned this in D11537: [Cashtab] [Chronik Websocket Notifications] [Part 6] Parse eToken txs from websocket msg.
emack requested changes to this revision.Jun 1 2022, 03:49
emack added a subscriber: emack.
emack added inline comments.
web/cashtab/src/utils/cashMethods.js
1011 ↗(On Diff #33726)

I think once this is deemed to be an outgoing tx you can break out of the rest of the loop to save time, rest looks good.

This revision now requires changes to proceed.Jun 1 2022, 03:49
emack mentioned this in D11538: [Cashtab] [Chronik Websocket Notifications] [Part 7] Display XEC notifications from ws msg.Jun 1 2022, 04:10
bytesofman added a child revision: D11537: [Cashtab] [Chronik Websocket Notifications] [Part 6] Parse eToken txs from websocket msg.Jun 1 2022, 23:51
bytesofman updated this revision to Diff 33830.Jun 6 2022, 17:30

Responding to feedback

Harbormaster completed remote builds in B19264: Diff 33830.Jun 6 2022, 17:33
emack accepted this revision.Jun 6 2022, 23:47
This revision is now accepted and ready to land.Jun 6 2022, 23:47
bytesofman updated this revision to Diff 33842.Jun 7 2022, 01:16

Rebase

Harbormaster completed remote builds in B19272: Diff 33842.Jun 7 2022, 01:19
Closed by commit rABC41d1bebc4393: [Cashtab] [Chronik Websocket Notifications] [Part 5] Parse XEC txs from… (authored by bytesofman). · Explain WhyJun 7 2022, 21:06
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC41d1bebc4393: [Cashtab] [Chronik Websocket Notifications] [Part 5] Parse XEC txs from….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__mocks__/
67 lines
__tests__/
25 lines
51 lines

Diff 33873

View Options

web/cashtab/src/utils/__mocks__/chronikWs.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...