Page MenuHomePhabricator
Differential D11533

[avalanche] Extract the compact proofs functional test to its own file
ClosedPublic
Actions

Authored by Fabien on May 30 2022, 14:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC97ab58a02f5a: [avalanche] Extract the compact proofs functional test to its own file
Summary

This is not really related to the proof inventories, and more tests are coming so better split it out. There is no change in behavior.

Depends on D11388.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_p2p_compactproofs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19218
Build 38184: Build Diffbuild-without-wallet · build-debug · build-clang-tidy · build-diff · build-clang
Build 38183: arc lint + arc unit

Event Timeline

Fabien created this revision.May 30 2022, 14:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2022, 14:11
Fabien requested review of this revision.May 30 2022, 14:11
Fabien edited the summary of this revision. (Show Details)May 30 2022, 14:11
Fabien added a parent revision: D11388: [avalanche] Answer getavaproofs message with short proof ids.
Harbormaster completed remote builds in B19178: Diff 33721.May 30 2022, 14:29
Fabien updated this revision to Diff 33723.May 30 2022, 15:37

Rebase

Harbormaster completed remote builds in B19180: Diff 33723.May 30 2022, 16:00
Mengerian added a subscriber: Mengerian.May 30 2022, 17:14
Mengerian added inline comments.
test/functional/abc_p2p_compactproofs.py
2 ↗(On Diff #33723)

Update the year?

Fabien updated this revision to Diff 33727.May 30 2022, 18:17

Fix copyright year

Harbormaster completed remote builds in B19184: Diff 33727.May 30 2022, 18:29
deadalnix accepted this revision.May 31 2022, 12:42
This revision is now accepted and ready to land.May 31 2022, 12:42
Fabien added a child revision: D11545: [avalanche] Request missing proofs from short ids.May 31 2022, 12:44
Fabien added a child revision: D11549: [avalanche] Request compact proofs from our avalanche outbound peers.Jun 1 2022, 09:14
Fabien removed a child revision: D11545: [avalanche] Request missing proofs from short ids.Jun 1 2022, 10:02
Fabien updated this revision to Diff 33770.Jun 1 2022, 15:17

Remove unused p2p store

Harbormaster completed remote builds in B19218: Diff 33770.Jun 1 2022, 15:32
Closed by commit rABC97ab58a02f5a: [avalanche] Extract the compact proofs functional test to its own file (authored by Fabien). · Explain WhyJun 6 2022, 14:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC97ab58a02f5a: [avalanche] Extract the compact proofs functional test to its own file.
Fabien mentioned this in D11652: [avalanche] Deduplicate the getavaproofs response test.Jun 21 2022, 14:18
Fabien mentioned this in rABC58fc5dc0aa2d: [avalanche] Deduplicate the getavaproofs response test.Jun 21 2022, 17:13

Revision Contents
Changeset List

PathSize
test/
functional/
82 lines
51 lines
1 line

Diff 33770

View Options

test/functional/abc_p2p_compactproofs.py

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...
View Options

test/functional/test_runner.py

Loading...