[avalanche] Add network permission for a peer to send unrequested compact proofs
AbandonedPublic
Actions

Authored by Fabien on May 31 2022, 12:10.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Processing compact proofs can be time consuming as the node has to loop over all its proofs to match against each short id. In order to prevent a peer from vasting our CPU time only the compact proofs message (avaproofs) that have been requested will be processed.

This diff adds a new network permission that bypass this and let a peer send unrequested compact proofs. This will make it much easier to test the behavior of a node receiving such a message in functional tests.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_pf_cmpctproofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19197
Build 38142: Build Diff	build-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 38141: arc lint + arc unit

Event Timeline

Fabien created this revision.May 31 2022, 12:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2022, 12:10

Fabien requested review of this revision.May 31 2022, 12:10

Harbormaster completed remote builds in B19197: Diff 33744.May 31 2022, 12:27

I don't understand what's the purpose of this. At no point we should expect a node to send the whole set of proof without being requested. I don't think solves any problem.

This revision now requires changes to proceed.May 31 2022, 12:42

Fabien added a child revision: D11545: [avalanche] Request missing proofs from short ids.May 31 2022, 12:44

Fabien removed a child revision: D11545: [avalanche] Request missing proofs from short ids.May 31 2022, 14:10

Fabien abandoned this revision.Jun 10 2022, 23:29