One of the overflow test added in D11515 is not doing what is expected, due to a couple errors:
- the MAX_SIZE value is a compact size difference value, so the indexes should increment by MAX_SIZE+1
- the loop size if off by one
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABCb903236dd018: Fix off by one errors in the difference fomatter serialize_tests
ninja check-bitcoin-serialize_tests
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/test/serialize_tests.cpp | ||
|---|---|---|
| 509 ↗ | (On Diff #33813) | Instead of trusting that this version of the test is correct, is it possible to write this in a way that you copy ss and check that remainder - 1 does not overflow? Basically do what your test plan does, but in the test itself. |