Differential D11573

Consistently use the calculate_shortid facility in functional tests
ClosedPublic
Actions

Authored by Fabien on Jun 7 2022, 07:51.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc9d5caf28fc1: Consistently use the calculate_shortid facility in functional tests

Summary

I figured out that the function exists, so let's use it. There is no change in behavior.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

calculate_shortid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19279
Build 38305: Build Diff	build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 38304: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 7 2022, 07:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2022, 07:51

Fabien requested review of this revision.Jun 7 2022, 07:51

Harbormaster completed remote builds in B19279: Diff 33849.Jun 7 2022, 08:07

PiRK accepted this revision.Jun 7 2022, 08:23

This revision is now accepted and ready to land.Jun 7 2022, 08:23

Closed by commit rABCc9d5caf28fc1: Consistently use the calculate_shortid facility in functional tests (authored by Fabien). · Explain WhyJun 7 2022, 08:25

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc9d5caf28fc1: Consistently use the calculate_shortid facility in functional tests.

Fabien mentioned this in D11545: [avalanche] Request missing proofs from short ids.Jun 7 2022, 09:38

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_compactproofs.py

6 lines

abc_p2p_proof_inventory.py

6 lines

Diff 33849

View Options

test/functional/abc_p2p_compactproofs.py