rpc: Remove unnecessary casting of block height
ClosedPublic
Actions

Authored by PiRK on Jun 8 2022, 15:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC3d100ae1b786: rpc: Remove unnecessary casting of block height

Summary

One of the two occurences in Bitcoin Core was already fixed in Bitcoin ABC.

This is a backport of core#21391 [13/14]
https://github.com/bitcoin/bitcoin/pull/21391/commits/f99913969f92b8b9cef1b83f5ee8e6a9267b4af0

Depends on D11587

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19308
Build 38356: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38355: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 8 2022, 15:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2022, 15:30

PiRK requested review of this revision.Jun 8 2022, 15:30

teamcity edited the summary of this revision. (Show Details)Jun 8 2022, 15:30

PiRK added a child revision: D11589: rpc/rest: Take and reuse local Chain/ChainState obj.Jun 8 2022, 15:32

PiRK edited the summary of this revision. (Show Details)Jun 8 2022, 15:33

Harbormaster completed remote builds in B19308: Diff 33897.Jun 8 2022, 16:04

Fabien accepted this revision.Jun 9 2022, 15:11

This revision is now accepted and ready to land.Jun 9 2022, 15:11

rebase

Harbormaster completed remote builds in B19323: Diff 33922.Jun 9 2022, 16:06

Closed by commit rABC3d100ae1b786: rpc: Remove unnecessary casting of block height (authored by PiRK). · Explain WhyJun 9 2022, 16:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3d100ae1b786: rpc: Remove unnecessary casting of block height.

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

2 lines

Diff 33897

View Options

rpc: Remove unnecessary casting of block heightClosedPublicActions