Page MenuHomePhabricator
Differential D11589

rpc/rest: Take and reuse local Chain/ChainState obj
ClosedPublic
Actions

Authored by PiRK on Jun 8 2022, 15:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0aa5c2bddb00: rpc/rest: Take and reuse local Chain/ChainState obj
Summary

In all rest/rpc-related modules, if there are multiple calls to
ActiveChain{,State}(), and the calls fall under the same ::cs_main lock,
we can simply take a local reference and use/reuse it instead of calling
ActiveChain{,State}() again and again.

This concludes backport of core#21391 [14/14]
https://github.com/bitcoin/bitcoin/pull/21391/commits/586190f0b4740457cb86cba632e3d64e6dfe9b0c

Depends on D11588

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jun 8 2022, 15:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2022, 15:32
PiRK requested review of this revision.Jun 8 2022, 15:32
teamcity edited the summary of this revision. (Show Details)Jun 8 2022, 15:32
Harbormaster completed remote builds in B19309: Diff 33898.Jun 8 2022, 16:03
Fabien accepted this revision.Jun 9 2022, 15:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
1654 ↗(On Diff #33898)

Same as the other diff, this doesn't need the lock

This revision is now accepted and ready to land.Jun 9 2022, 15:16
PiRK updated this revision to Diff 33923.Jun 9 2022, 15:43

rebase

PiRK added a child revision: D11596: refactor: Pass hash_type to CoinsStats in stats object.Jun 9 2022, 15:57
Harbormaster completed remote builds in B19324: Diff 33923.Jun 9 2022, 16:10
Closed by commit rABC0aa5c2bddb00: rpc/rest: Take and reuse local Chain/ChainState obj (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJun 9 2022, 16:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0aa5c2bddb00: rpc/rest: Take and reuse local Chain/ChainState obj.

Revision Contents
Changeset List

PathSize
src/
rpc/
43 lines
21 lines
8 lines

Diff 33923

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...