rpc: Add Coinstats index to getindexinfo
ClosedPublic
Actions

Authored by PiRK on Jun 10 2022, 08:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b6d8c9d2c2e: rpc: Add Coinstats index to getindexinfo

Summary

This is a backport of core#19521 [9 & 10/17]
https://github.com/bitcoin/bitcoin/pull/19521/commits/ca01bb8d689f93e1c7669b0ba7a4994c0206dabd
https://github.com/bitcoin/bitcoin/pull/19521/commits/655d929836a71af23d2035d2e2e99ad8b8c340c3

Depends on D11600

Test Plan

ninja && test/functional/test_runner.py rpc_misc

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19343
Build 38423: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38422: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 10 2022, 08:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2022, 08:30

PiRK requested review of this revision.Jun 10 2022, 08:30

teamcity edited the summary of this revision. (Show Details)Jun 10 2022, 08:30

PiRK edited the summary of this revision. (Show Details)Jun 10 2022, 08:31

PiRK edited the test plan for this revision. (Show Details)

PiRK edited the summary of this revision. (Show Details)

PiRK added a parent revision: D11600: rpc: gettxoutsetinfo can be requested for specific blockheights.

Harbormaster completed remote builds in B19337: Diff 33944.Jun 10 2022, 08:33

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[340/518] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[341/518] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[342/518] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[343/518] Linking C static library src/secp256k1/libsecp256k1.a
[344/518] Linking CXX static library src/libbitcoinconsensus.a
[345/518] Linking C executable src/secp256k1/internal-bench
[346/518] Linking C executable src/secp256k1/sign-bench
[347/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[348/518] Linking C executable src/secp256k1/verify-bench
[349/518] Linking C executable src/secp256k1/recover-bench
[350/518] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[351/518] Linking C executable src/secp256k1/ecmult-bench
[352/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[353/518] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[354/518] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[355/518] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[356/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[357/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[358/518] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[359/518] Linking CXX static library src/libscript.a
[360/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[361/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[362/518] Linking CXX static library src/libcommon.a
[363/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[364/518] Linking CXX shared library src/libbitcoinconsensus.so.0.25.8
[365/518] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[366/518] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[367/518] Linking CXX executable src/bitcoin-cli
[368/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[369/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[370/518] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[371/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[372/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[373/518] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[374/518] Linking CXX executable src/bitcoin-tx
[375/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[376/518] Linking CXX static library src/zmq/libzmq.a
[377/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[378/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[379/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[380/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[381/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[382/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[384/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[385/518] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[386/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[387/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[388/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[389/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[390/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[391/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[392/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[393/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[394/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/518] Linking CXX static library src/wallet/libwallet.a
[396/518] Linking CXX static library src/wallet/libwallet-tool.a
[397/518] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

PiRK planned changes to this revision.Jun 10 2022, 08:40

PiRK added a child revision: D11605: rpc, index: Add verbose amounts tracking to Coinstats index.Jun 10 2022, 09:05

rebase

Harbormaster completed remote builds in B19343: Diff 33950.Jun 10 2022, 09:51

Fabien requested changes to this revision.Jun 10 2022, 23:02

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/rpc_misc.py
87	Why not using the same var name as the source, i.e. `i` ? This is calling for merge conflicts and i for index is super standard

This revision now requires changes to proceed.Jun 10 2022, 23:02

PiRK added inline comments.Jun 11 2022, 12:39

test/functional/rpc_misc.py
87	ok. It feels weird to use `i` for something that is not a list index (an integer), but I don't mind using the same name as the source material for the sake of avoiding future conflicts.