The getavaproofs requests are only requested upon connection for now, let send more on a regular basis. This will help keeping up to date even if we don't connect to new peers.
Depends on D11612.
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABC8c4ef5405fc6: [avalanche] Send getavaproofs periodically to one random peer
./test/functional/test_runner.py abc_p2p_compactproofs
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_send_getavaproofs_schedule
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19363 Build 38463: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 38462: arc lint + arc unit
Event Timeline
| src/net_processing.cpp | ||
|---|---|---|
| 1708 ↗ | (On Diff #33967) | In this case it will be a no op, so I don't see a reason to special case the empty vector |
| test/functional/abc_p2p_compactproofs.py | ||
| 102 ↗ | (On Diff #33967) | It should be ok as long as the test lasts less than 2 minutes, but you're right >= 1 is more correct here |