Page MenuHomePhabricator
Differential D11648

test/miner_tests: Pass in chain tip to CreateBlockIndex
ClosedPublic
Actions

Authored by PiRK on Jun 21 2022, 08:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCaeb423f1a182: test/miner_tests: Pass in chain tip to CreateBlockIndex
Summary

This is a backport of core#21866 [3/12]
https://github.com/bitcoin/bitcoin/pull/21866/commits/4d99b61014ba26eb1f3713df5528d2804edff165

Depends on D11647

Test Plan

ninja check

Diff Detail

Event Timeline

PiRK created this revision.Jun 21 2022, 08:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2022, 08:39
PiRK requested review of this revision.Jun 21 2022, 08:39
teamcity edited the summary of this revision. (Show Details)Jun 21 2022, 08:39
PiRK added a child revision: D11649: test: Pass in CoinsTip to ValidateCheckInputsForAllFlags.Jun 21 2022, 08:40
Harbormaster completed remote builds in B19428: Diff 34071.Jun 21 2022, 09:04
Fabien requested changes to this revision.Jun 21 2022, 10:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/miner_tests.cpp
521 ↗(On Diff #34071)

ActiveTip()

553 ↗(On Diff #34071)

ActiveHeight()

558 ↗(On Diff #34071)

Dito

562 ↗(On Diff #34071)

Dito

This revision now requires changes to proceed.Jun 21 2022, 10:53
PiRK updated this revision to Diff 34075.Jun 21 2022, 13:25

use ActiveHeight() and ActiveTip() for nullptr dereference protection in case the tip is null

Harbormaster completed remote builds in B19432: Diff 34075.Jun 21 2022, 13:41
Fabien accepted this revision.Jun 21 2022, 14:06
This revision is now accepted and ready to land.Jun 21 2022, 14:06
Closed by commit rABCaeb423f1a182: test/miner_tests: Pass in chain tip to CreateBlockIndex (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyJun 22 2022, 07:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCaeb423f1a182: test/miner_tests: Pass in chain tip to CreateBlockIndex.

Revision Contents
Changeset List

PathSize
src/
test/
18 lines

Diff 34075

View Options

src/test/miner_tests.cpp

Loading...