Differential D1165

Add friendly output to dumpwallet
ClosedPublic
Actions

Authored by deadalnix on Mar 5 2018, 14:21.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING291a6ce84054: Add friendly output to dumpwallet
rABC291a6ce84054: Add friendly output to dumpwallet

Summary

Backport core's PR9740

Test Plan

make check
./test/functional/test_runner.py wallet-dump

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Mar 5 2018, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2018, 14:21

deadalnix added a child revision: D1166: rpc: Prevent `dumpwallet` from overwriting files.Mar 5 2018, 14:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1990: Diff 3065.Mar 5 2018, 14:51

schancel requested changes to this revision.Mar 5 2018, 18:27

schancel added a subscriber: schancel.

schancel added inline comments.

src/wallet/rpcdump.cpp
699 ↗	(On Diff #3065)	Does this truncate the file? Also, is there any check to ensure that the dump file is not overlapping with the wallet, or other important files on the filesystem? If not, there should be.

This revision now requires changes to proceed.Mar 5 2018, 18:27

deadalnix requested review of this revision.Mar 5 2018, 18:37

deadalnix added inline comments.

src/wallet/rpcdump.cpp
699 ↗	(On Diff #3065)	D1166

schancel accepted this revision.Mar 5 2018, 20:22

This revision is now accepted and ready to land.Mar 5 2018, 20:22

Closed by commit rABC291a6ce84054: Add friendly output to dumpwallet (authored by aideca <aideca@users.noreply.github.com>, committed by deadalnix). · Explain WhyMar 5 2018, 21:30

This revision was automatically updated to reflect the committed changes.

nakihito mentioned this in D5057: Merge #13982: refactor: use fs:: over boost::filesystem::.Jan 23 2020, 19:03

nakihito mentioned this in rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.Jan 24 2020, 18:02

nakihito mentioned this in rSTAGING8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::.Apr 7 2020, 22:38

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

18 lines

test/

functional/

wallet-dump.py

7 lines

Diff 3087

View Options

src/wallet/rpcdump.cpp