Page MenuHomePhabricator

[avalanche] Don't request compact proofs during IBD
ClosedPublic

Authored by Fabien on Jun 23 2022, 15:07.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC2b3fd80e90cd: [avalanche] Don't request compact proofs during IBD
Summary

There is little chance to get valuable outcome from compact proofs during IBD, because we can't know if the staked utxos have been spent. We will be requesting them aggressively after IBD complete.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_no_compactproof_ibd
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19452
Build 38637: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38636: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jun 23 2022, 15:07
sdulfari added a subscriber: sdulfari.

The summary could be improved to describe why this is the right way forward. It's not immediately obvious why collecting proofs during IBD is low-value, especially since we bother to track orphans.

This revision is now accepted and ready to land.Jun 23 2022, 19:03