Page MenuHomePhabricator
Differential D11712

[Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs
ClosedPublic
Actions

Authored by emack on Jul 5 2022, 07:23.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC857269848c1e: [Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs
Summary

As per T2503, this is part of a series of diffs to refactor the transaction generation process within useBCH.

This diff is a standalone utility function which parses the input UTXOs for the address at element 0. If that particular address is invalid, then the function falls back onto the wallet's Path1899 cash address.

Test Plan

npm test
observe successful execution of buildTx() unit tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
changeAddress
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19574
Build 38867: Build Diffcashtab-tests
Build 38866: arc lint + arc unit

Event Timeline

emack created this revision.Jul 5 2022, 07:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2022, 07:23
emack requested review of this revision.Jul 5 2022, 07:23
Harbormaster completed remote builds in B19555: Diff 34246.Jul 5 2022, 07:30
bytesofman requested changes to this revision.Jul 5 2022, 18:05
bytesofman added inline comments.
web/cashtab/src/utils/cashMethods.js
18 ↗(On Diff #34246)

These BLOCKCAPS_UNDERSCORED variables are artifacts from I can't even remember. Do not preserve them in this standalone function.

Call it changeAddress everywhere for clarity + consistency.

29 ↗(On Diff #34246)

Don't include this fallback. If the input utxo has an invalid address, we got problems --- the tx should fail.

This revision now requires changes to proceed.Jul 5 2022, 18:05
emack updated this revision to Diff 34270.Jul 6 2022, 05:20
emack marked 2 inline comments as done.
  • Removed fallback to Path1899 address
  • Added unit test coverage for malformed input utxo and valid input utxo with invalid address params
  • Updated variable names
Harbormaster completed remote builds in B19574: Diff 34270.Jul 6 2022, 05:23
bytesofman requested changes to this revision.Jul 6 2022, 23:16
bytesofman added inline comments.
web/cashtab/src/utils/cashMethods.js
16

This comment should read "Assume change address is input address of utxo at index 0"

17

Remove this comment

This revision now requires changes to proceed.Jul 6 2022, 23:16
emack updated this revision to Diff 34294.Jul 7 2022, 12:13
emack marked 2 inline comments as done.

Updated comments

Harbormaster completed remote builds in B19589: Diff 34294.Jul 7 2022, 12:17
bytesofman accepted this revision.Jul 7 2022, 21:02
This revision is now accepted and ready to land.Jul 7 2022, 21:02
Closed by commit rABC857269848c1e: [Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs (authored by emack). · Explain WhyJul 13 2022, 12:55
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC857269848c1e: [Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs.
emack mentioned this in D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.Jul 17 2022, 09:02
emack mentioned this in D12045: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.Sep 23 2022, 08:45
emack mentioned this in rABC4110ce80157b: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.Sep 24 2022, 13:50

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
__tests__/
97 lines
19 lines

Diff 34270

View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...