[Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs
ClosedPublic
Actions

Authored by emack on Jul 5 2022, 07:23.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC857269848c1e: [Cashtab] [Chronik] [Tx Gen] Get change address from input UTXOs

Summary

As per T2503, this is part of a series of diffs to refactor the transaction generation process within useBCH.

This diff is a standalone utility function which parses the input UTXOs for the address at element 0. If that particular address is invalid, then the function falls back onto the wallet's Path1899 cash address.

Test Plan

npm test
observe successful execution of buildTx() unit tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Jul 5 2022, 07:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2022, 07:23

emack requested review of this revision.Jul 5 2022, 07:23

Harbormaster completed remote builds in B19555: Diff 34246.Jul 5 2022, 07:30

bytesofman requested changes to this revision.Jul 5 2022, 18:05

bytesofman added inline comments.

web/cashtab/src/utils/cashMethods.js
18 ↗	(On Diff #34246)	These BLOCKCAPS_UNDERSCORED variables are artifacts from I can't even remember. Do not preserve them in this standalone function. Call it `changeAddress` everywhere for clarity + consistency.
29 ↗	(On Diff #34246)	Don't include this fallback. If the input utxo has an invalid address, we got problems --- the tx should fail.

This revision now requires changes to proceed.Jul 5 2022, 18:05

Removed fallback to Path1899 address
Added unit test coverage for malformed input utxo and valid input utxo with invalid address params
Updated variable names

Harbormaster completed remote builds in B19574: Diff 34270.Jul 6 2022, 05:23

bytesofman requested changes to this revision.Jul 6 2022, 23:16

bytesofman added inline comments.