Paths

Table of Contentst

Differential D11731

[cashtab-components] Replace all instances of CashTab with Cashtab
ClosedPublic
Actions

Authored by kieran709 on Jul 7 2022, 18:27.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC1224b79d4b42: [cashtab-components] Replace all instances of CashTab with Cashtab

Summary

Replaced all instance of CashTab with Cashtab in cashtab-components. Related to task T2537.

Test Plan

cd web
grep -r 'CashTab' cashtab-components/ should return no results

cd cashtab
grep -r 'CashTab' extension/ should return no results (excluding files in dist dir)

Then:

cd web/cashtab
npm run extension
confirm that clicking on a cashtab badge button still opens the extension

cd web/cashtab-components
npm run storybook
Confirm that storybook runs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

replace-cashTab-with-cashtab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19617
Build 38953: Build Diff	cashtab-tests · cashtab-components-tests
Build 38952: arc lint + arc unit

Event Timeline

kieran709 created this revision.Jul 7 2022, 18:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2022, 18:27

kieran709 requested review of this revision.Jul 7 2022, 18:27

Harbormaster completed remote builds in B19596: Diff 34303.Jul 7 2022, 18:31

bytesofman requested changes to this revision.Jul 7 2022, 21:27

bytesofman added inline comments.

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
190 ↗	(On Diff #34303)	This is correct -- but this is also a good example of why we are using a mono-repo here. This change impacts how the components communicate with the browser extension. See `web/cashtab/src/extension/src/background.js` This change needs to be made there as well Also review the README.md and web/cashtab/extension/src/contentscript.js files

This revision now requires changes to proceed.Jul 7 2022, 21:27

kieran709 added inline comments.Jul 7 2022, 23:46

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx
190 ↗	(On Diff #34303)	Good catch thank you. Should I also update instances of 'CashTab' in the extension/dist dir?

kieran709 edited the test plan for this revision. (Show Details)Jul 8 2022, 14:58

responding to review feedback

Harbormaster completed remote builds in B19604: Diff 34313.Jul 8 2022, 15:02

Bump version number for extension and cashtab-components
Test plan needs to include:

cd web/cashtab
npm run extension
cd web/cashtab-components
npm run storybook

& confirm that clicking on a cashtab badge button still opens the extension

This revision now requires changes to proceed.Jul 11 2022, 22:40

kieran709 edited the test plan for this revision. (Show Details)Jul 12 2022, 14:59

storybook-failed-to-fetch.png (526×673 px, 61 KB)

I don't think it is related to this diff, but in storybook, all of the CashtabButton components are throwing this error.

Bumped extension version in web/cashtab/extension/public/manifest.json, and cashtab-components storybook version in web/cashtab-components/package.json. Updated test plan per review feedback.

Harbormaster completed remote builds in B19617: Diff 34335.Jul 12 2022, 15:13

In D11731#263184, @kieran709 wrote:

I don't think it is related to this diff, but in storybook, all of the CashtabButton components are throwing this error.

T2558 created for this, thanks

bytesofman accepted this revision.Jul 12 2022, 19:51

This revision is now accepted and ready to land.Jul 12 2022, 19:51

Closed by commit rABC1224b79d4b42: [cashtab-components] Replace all instances of CashTab with Cashtab (authored by kieran709). · Explain WhyJul 13 2022, 12:24

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC1224b79d4b42: [cashtab-components] Replace all instances of CashTab with Cashtab.