Paths

Table of Contentst

Differential D11777

[Cashtab] Mock getRawTransaction API calls in unit tests
ClosedPublic
Actions

Authored by bytesofman on Jul 20 2022, 21:51.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC33a12b58d775: [Cashtab] Mock getRawTransaction API calls in unit tests

Summary

T2577

Earlier review missed this API call, which only applies for received txs. This diff mocks the API call, patching longstanding bug in unit tests covered by replyAddress: null from earlier error.

Paves the way for D11672

Test Plan

Review the new mocks
npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-parsetxdata-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19682
Build 39083: Build Diff	cashtab-tests
Build 39082: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 20 2022, 21:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2022, 21:51

bytesofman requested review of this revision.Jul 20 2022, 21:51

bytesofman mentioned this in D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.Jul 20 2022, 21:52

Harbormaster completed remote builds in B19682: Diff 34441.Jul 20 2022, 21:54

emack accepted this revision.Jul 21 2022, 03:21

This revision is now accepted and ready to land.Jul 21 2022, 03:21

Closed by commit rABC33a12b58d775: [Cashtab] Mock getRawTransaction API calls in unit tests (authored by bytesofman). · Explain WhyJul 21 2022, 04:42

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC33a12b58d775: [Cashtab] Mock getRawTransaction API calls in unit tests.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__mocks__/

mockParseTxDataRawTxs.js

204 lines

mockParsedTxs.js

7 lines

__tests__/

useBCH.test.js

15 lines

Diff 34441

View Options

web/cashtab/src/hooks/mocks/mockParseTxDataRawTxs.js

View Options

web/cashtab/src/hooks/mocks/mockParsedTxs.js

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

[Cashtab] Mock getRawTransaction API calls in unit testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34441

web/cashtab/src/hooks/__mocks__/mockParseTxDataRawTxs.js

web/cashtab/src/hooks/__mocks__/mockParsedTxs.js

web/cashtab/src/hooks/__tests__/useBCH.test.js

[Cashtab] Mock getRawTransaction API calls in unit tests
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/hooks/mocks/mockParseTxDataRawTxs.js

web/cashtab/src/hooks/mocks/mockParsedTxs.js

web/cashtab/src/hooks/tests/useBCH.test.js