Paths

Table of Contentst

Differential D11672

[avalanche] Simplify the proof reconciliation logic
ClosedPublic
Actions

Authored by Fabien on Jun 27 2022, 20:02.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6a743626db33: [avalanche] Simplify the proof reconciliation logic

Summary

This diff moves some of the logic surrounding addProofToReconcile and deduplicate some other. The isWorthPolling method now takes care of determining if the proof needs to be voted on and we can leverage this to simplify the code in the network layer. It also makes it easier to use the addProofToReconcile method.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 27 2022, 20:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 27 2022, 20:02

Fabien requested review of this revision.Jun 27 2022, 20:02

Harbormaster completed remote builds in B19486: Diff 34154.Jun 27 2022, 20:19

Fabien added a child revision: D11677: [avalanche] Poll for unorphaned proofs.Jun 28 2022, 14:43

PiRK accepted this revision.Jun 29 2022, 15:46

This revision is now accepted and ready to land.Jun 29 2022, 15:46

Closed by commit rABC6a743626db33: [avalanche] Simplify the proof reconciliation logic (authored by Fabien). · Explain WhyJun 29 2022, 19:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a743626db33: [avalanche] Simplify the proof reconciliation logic.

bytesofman mentioned this in D11777: [Cashtab] Mock getRawTransaction API calls in unit tests.Jul 20 2022, 21:51

bytesofman mentioned this in rABC33a12b58d775: [Cashtab] Mock getRawTransaction API calls in unit tests.Jul 21 2022, 04:42

Revision Contents
Changeset List

Path

Size

src/

avalanche/

7 lines

test/

processor_tests.cpp

33 lines

net_processing.cpp

20 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

10 lines

Diff 34184

src/avalanche/processor.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...