Page MenuHomePhabricator

[avalanche] Simplify the proof reconciliation logic
ClosedPublic

Authored by Fabien on Jun 27 2022, 20:02.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC6a743626db33: [avalanche] Simplify the proof reconciliation logic
Summary

This diff moves some of the logic surrounding addProofToReconcile and deduplicate some other. The isWorthPolling method now takes care of determining if the proof needs to be voted on and we can leverage this to simplify the code in the network layer. It also makes it easier to use the addProofToReconcile method.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_simplifly_addprooftoreconcile_logic
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19486
Build 38705: Build Diffbuild-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 38704: arc lint + arc unit