Differential D11780
[refactor] const ATMPArgs and non-const Workspace Authored by PiRK on Jul 21 2022, 10:07. Tags None Subscribers None
Details
ATMPArgs should contain const arguments for validation. This is a backport of core#21062 [3/4] Note: changes related to RBF are not applicable ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tail of the build log: [0m[0;32mwallet_labels.py --descriptors | ✓ Passed | 2 s [0m[0;32mwallet_listreceivedby.py | ✓ Passed | 27 s [0m[0;32mwallet_listsinceblock.py | ✓ Passed | 8 s [0m[0;32mwallet_listsinceblock.py --descriptors | ✓ Passed | 10 s [0m[0;32mwallet_listtransactions.py | ✓ Passed | 5 s [0m[0;32mwallet_listtransactions.py --descriptors | ✓ Passed | 3 s [0m[0;32mwallet_multiwallet.py | ✓ Passed | 23 s [0m[0;32mwallet_multiwallet.py --usecli | ✓ Passed | 17 s [0m[0;32mwallet_reorgsrestore.py | ✓ Passed | 4 s [0m[0;32mwallet_resendwallettransactions.py | ✓ Passed | 6 s [0m[0;32mwallet_send.py | ✓ Passed | 9 s [0m[0;32mwallet_startup.py | ✓ Passed | 3 s [0m[0;32mwallet_txn_clone.py | ✓ Passed | 3 s [0m[0;32mwallet_txn_clone.py --mineblock | ✓ Passed | 4 s [0m[0;32mwallet_txn_doublespend.py | ✓ Passed | 3 s [0m[0;32mwallet_txn_doublespend.py --mineblock | ✓ Passed | 4 s [0m[0;32mwallet_watchonly.py | ✓ Passed | 1 s [0m[0;32mwallet_watchonly.py --usecli | ✓ Passed | 2 s [0m[1m ALL | ✓ Passed | 2080 s (accumulated) [0mRuntime: 418 s ---------------------------------------------------------------------- Ran 10 tests in 0.209s OK [160/480] Test Bitcoin RPC authentication... ... ---------------------------------------------------------------------- Ran 3 tests in 0.004s OK [161/480] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py ..... ---------------------------------------------------------------------- Ran 5 tests in 0.001s OK [183/480] Running seeder test suite PASSED: seeder test suite [322/480] avalanche: testing peermanager_tests FAILED: src/avalanche/test/CMakeFiles/check-avalanche-peermanager_tests cd /work/abc-ci-builds/build-debug/src/avalanche/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/avalanche-peermanager_tests.log /work/abc-ci-builds/build-debug/src/avalanche/test/test-avalanche --run_test=peermanager_tests --logger=HRF,message:JUNIT,message,avalanche-peermanager_tests.xml --catch_system_errors=no Running 29 test cases... ../../src/avalanche/test/peermanager_tests.cpp(1480): error: in "peermanager_tests/should_request_more_nodes": check pm.shouldRequestMoreNodes() has failed ../../src/avalanche/test/peermanager_tests.cpp(1488): error: in "peermanager_tests/should_request_more_nodes": check !pm.addNode(11, proof2->getId()) has failed ../../src/avalanche/test/peermanager_tests.cpp(1489): error: in "peermanager_tests/should_request_more_nodes": check pm.registerProof(proof2) has failed *** 3 failures are detected in the test module "Avalanche Test Suite" [437/480] Running secp256k1 test suite PASSED: secp256k1 test suite [463/480] Running bitcoin-qt test suite PASSED: bitcoin-qt test suite [468/480] Running pow test suite PASSED: pow test suite [477/480] Running bitcoin test suite PASSED: bitcoin test suite ninja: build stopped: cannot make progress due to previous errors. Build build-debug failed with exit code 1 |