Page MenuHomePhabricator

[refactor] const ATMPArgs and non-const Workspace
ClosedPublic

Authored by PiRK on Jul 21 2022, 10:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9aa6dcdcc32a: [refactor] const ATMPArgs and non-const Workspace
Summary

ATMPArgs should contain const arguments for validation.
The Workspace should contain state that may change
throughout validation.

This is a backport of core#21062 [3/4]
https://github.com/bitcoin/bitcoin/pull/21062/commits/174cb5330af4b09f3a66974d3bae783ea43b190e

Note: changes related to RBF are not applicable
Depends on D11779

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Jul 21 2022, 10:07

Tail of the build log:

wallet_labels.py --descriptors                         | ✓ Passed  | 2 s
wallet_listreceivedby.py                               | ✓ Passed  | 27 s
wallet_listsinceblock.py                               | ✓ Passed  | 8 s
wallet_listsinceblock.py --descriptors                 | ✓ Passed  | 10 s
wallet_listtransactions.py                             | ✓ Passed  | 5 s
wallet_listtransactions.py --descriptors               | ✓ Passed  | 3 s
wallet_multiwallet.py                                  | ✓ Passed  | 23 s
wallet_multiwallet.py --usecli                         | ✓ Passed  | 17 s
wallet_reorgsrestore.py                                | ✓ Passed  | 4 s
wallet_resendwallettransactions.py                     | ✓ Passed  | 6 s
wallet_send.py                                         | ✓ Passed  | 9 s
wallet_startup.py                                      | ✓ Passed  | 3 s
wallet_txn_clone.py                                    | ✓ Passed  | 3 s
wallet_txn_clone.py --mineblock                        | ✓ Passed  | 4 s
wallet_txn_doublespend.py                              | ✓ Passed  | 3 s
wallet_txn_doublespend.py --mineblock                  | ✓ Passed  | 4 s
wallet_watchonly.py                                    | ✓ Passed  | 1 s
wallet_watchonly.py --usecli                           | ✓ Passed  | 2 s

ALL                                                    | ✓ Passed  | 2080 s (accumulated) 
Runtime: 418 s

----------------------------------------------------------------------
Ran 10 tests in 0.209s

OK

[160/480] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[161/480] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[183/480] Running seeder test suite
PASSED: seeder test suite
[322/480] avalanche: testing peermanager_tests
FAILED: src/avalanche/test/CMakeFiles/check-avalanche-peermanager_tests 
cd /work/abc-ci-builds/build-debug/src/avalanche/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/avalanche-peermanager_tests.log /work/abc-ci-builds/build-debug/src/avalanche/test/test-avalanche --run_test=peermanager_tests --logger=HRF,message:JUNIT,message,avalanche-peermanager_tests.xml --catch_system_errors=no
Running 29 test cases...
../../src/avalanche/test/peermanager_tests.cpp(1480): error: in "peermanager_tests/should_request_more_nodes": check pm.shouldRequestMoreNodes() has failed
../../src/avalanche/test/peermanager_tests.cpp(1488): error: in "peermanager_tests/should_request_more_nodes": check !pm.addNode(11, proof2->getId()) has failed
../../src/avalanche/test/peermanager_tests.cpp(1489): error: in "peermanager_tests/should_request_more_nodes": check pm.registerProof(proof2) has failed

*** 3 failures are detected in the test module "Avalanche Test Suite"
[437/480] Running secp256k1 test suite
PASSED: secp256k1 test suite
[463/480] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[468/480] Running pow test suite
PASSED: pow test suite
[477/480] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
This revision is now accepted and ready to land.Jul 21 2022, 19:51
This revision was landed with ongoing or failed builds.Jul 22 2022, 06:53
This revision was automatically updated to reflect the committed changes.