Differential D11783

[build] Fix doxygen documentation issues and enable -Wdocumentation
ClosedPublic
Actions

Authored by PiRK on Jul 21 2022, 13:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf83e0a6af7cb: [build] Fix doxygen documentation issues and enable -Wdocumentation

Summary

This fixes documentation errors, such as wrong parameter names, empty documentation for a parameter, documentation not located next to the targetted function.

This is a backport of core#21613

Test Plan

cd build
ccache --clear
rm -Rf *
cmake .. -Ninja -DCMAKE_CXX_COMPILER=clang++
ninja
ninja doc-doxygen

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 21 2022, 13:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2022, 13:47

PiRK requested review of this revision.Jul 21 2022, 13:47

PiRK edited the summary of this revision. (Show Details)Jul 21 2022, 13:53

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B19688: Diff 34453.Jul 21 2022, 14:06

Fabien accepted this revision.Jul 21 2022, 20:02

This revision is now accepted and ready to land.Jul 21 2022, 20:02

Closed by commit rABCf83e0a6af7cb: [build] Fix doxygen documentation issues and enable -Wdocumentation (authored by PiRK). · Explain WhyJul 22 2022, 06:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf83e0a6af7cb: [build] Fix doxygen documentation issues and enable -Wdocumentation.

Revision Contents
Changeset List

Path

Size

src/

1 line

14 lines

14 lines

2 lines

util/

2 lines

2 lines

2 lines

4 lines

wallet/

coinselection.cpp

32 lines

scriptpubkeyman.cpp

2 lines

Diff 34463

View Options

src/CMakeLists.txt

View Options

src/cuckoocache.h

View Options

src/net_processing.cpp

View Options

src/netbase.h

View Options

src/util/message.h

View Options

src/util/sock.h

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/wallet/coinselection.cpp

View Options

src/wallet/scriptpubkeyman.cpp

[build] Fix doxygen documentation issues and enable -WdocumentationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34463

src/CMakeLists.txt

src/cuckoocache.h

src/net_processing.cpp

src/netbase.h

src/util/message.h

src/util/sock.h

src/validation.h

src/validation.cpp

src/wallet/coinselection.cpp

src/wallet/scriptpubkeyman.cpp

[build] Fix doxygen documentation issues and enable -Wdocumentation
ClosedPublic
Actions

Revision Contents
Changeset List