[Chronik] Add `ENABLE_CHRONIK` #define macro
ClosedPublic
Actions

Authored by tobias_ruck on Jul 26 2022, 19:19.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC68ac3d500882: [Chronik] Add `ENABLE_CHRONIK` #define macro

Summary

This is required for conditional compilation in the C++ code depending on whether Chronik is enabled.

Test Plan

cmake with -DBUILD_BITCOIN_CHRONIK=ON generates #define ENABLE_CHRONIK 1 in build/src/config/bitcoin-config.h
cmake with -DBUILD_BITCOIN_CHRONIK=OFF generates #define ENABLE_CHRONIK 0 in build/src/config/bitcoin-config.h

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-enable-macro

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19738
Build 39195: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-diff · build-clang-tidy · build-clang
Build 39194: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jul 26 2022, 19:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 26 2022, 19:19

tobias_ruck requested review of this revision.Jul 26 2022, 19:19

Harbormaster completed remote builds in B19730: Diff 34523.Jul 26 2022, 19:38

tobias_ruck added a child revision: D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.Jul 26 2022, 19:41

You are missing the option(BUILD_BITCOIN_CHRONIK) statement.
Also please expand on the test plan to check the option creates the expected defines when set.

src/config/bitcoin-config.h.cmake.in
76 ↗	(On Diff #34523)	That's a weird location for this define. Either move it in it's own place with a short comment or at least keep the lexical ordering. Also chronik should be opt-in, so 0 is a better default.