Page MenuHomePhabricator
Differential D11816

[avalanche] Don't download proofs during IBD
ClosedPublic
Actions

Authored by Fabien on Jul 29 2022, 14:22.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC3501c57cc5f6: [avalanche] Don't download proofs during IBD
Summary

We already avoid requesting compact proofs, but this extends to relayed proofs as well.
This diffs prevents the node from requesting proofs when an inv is received during IBD, and also discards the proofs received via the network in the event a peer sent us spontaneously a proof.

Depends on D11815.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 29 2022, 14:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 29 2022, 14:22
Fabien requested review of this revision.Jul 29 2022, 14:22
Harbormaster completed remote builds in B19752: Diff 34554.Jul 29 2022, 14:40
sdulfari requested changes to this revision.Jul 29 2022, 18:41
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_proof_inventory.py
218 ↗(On Diff #34554)

is there a reason to not restart all of the nodes?

This revision now requires changes to proceed.Jul 29 2022, 18:41
Fabien updated this revision to Diff 34564.Jul 30 2022, 07:38

Restart all nodes for clarity

Harbormaster completed remote builds in B19758: Diff 34564.Jul 30 2022, 07:56
sdulfari accepted this revision.Jul 31 2022, 05:52
This revision is now accepted and ready to land.Jul 31 2022, 05:52
Closed by commit rABC3501c57cc5f6: [avalanche] Don't download proofs during IBD (authored by Fabien). · Explain WhyJul 31 2022, 19:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC3501c57cc5f6: [avalanche] Don't download proofs during IBD.

Revision Contents
Changeset List

PathSize
src/
10 lines
test/
functional/
16 lines
56 lines

Diff 34566

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_quorum.py

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...