Page MenuHomePhabricator

[avalanche] Don't download proofs during IBD
ClosedPublic

Authored by Fabien on Fri, Jul 29, 14:22.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC3501c57cc5f6: [avalanche] Don't download proofs during IBD
Summary

We already avoid requesting compact proofs, but this extends to relayed proofs as well.
This diffs prevents the node from requesting proofs when an inv is received during IBD, and also discards the proofs received via the network in the event a peer sent us spontaneously a proof.

Depends on D11815.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Fri, Jul 29, 14:22
sdulfari requested changes to this revision.Fri, Jul 29, 18:41
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
test/functional/abc_p2p_proof_inventory.py
218 ↗(On Diff #34554)

is there a reason to not restart all of the nodes?

This revision now requires changes to proceed.Fri, Jul 29, 18:41

Restart all nodes for clarity

This revision is now accepted and ready to land.Sun, Jul 31, 05:52
This revision was automatically updated to reflect the committed changes.