Differential D11921

[avalanche] Deprecate the -enableavalancheproofreplacement flag
ClosedPublic
Actions

Authored by Fabien on Sep 6 2022, 14:07.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4f21390a80e5: [avalanche] Deprecate the -enableavalancheproofreplacement flag

Summary

Make it always true, there is no point disabling that feature anymore after the remaining tests are updated to manage the replacement.

Depends on D11915 and D11919.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_deprecate_proofreplacement

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19936
Build 39578: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39577: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 6 2022, 14:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2022, 14:07

Fabien requested review of this revision.Sep 6 2022, 14:07

Fabien added a child revision: D11922: [avalanche] Deprecate the -enableavalanche flag.Sep 6 2022, 14:24

Harbormaster completed remote builds in B19936: Diff 34826.Sep 6 2022, 14:31

PiRK accepted this revision.Sep 7 2022, 15:48

This revision is now accepted and ready to land.Sep 7 2022, 15:48

Closed by commit rABC4f21390a80e5: [avalanche] Deprecate the -enableavalancheproofreplacement flag (authored by Fabien). · Explain WhySep 8 2022, 07:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4f21390a80e5: [avalanche] Deprecate the -enableavalancheproofreplacement flag.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

avalanche.h

5 lines

peermanager.cpp

23 lines

processor.cpp

7 lines

test/

init_tests.cpp

7 lines

peermanager_tests.cpp

31 lines

processor_tests.cpp

19 lines

init.cpp

5 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

19 lines

abc_p2p_getavaaddr.py

1 line

abc_rpc_avalancheproof.py

1 line

abc_rpc_getavalancheinfo.py

1 line

Diff 34826

View Options

src/avalanche/avalanche.h

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/init_tests.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/init.cpp

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_getavaaddr.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

[avalanche] Deprecate the -enableavalancheproofreplacement flagClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34826

src/avalanche/avalanche.h

src/avalanche/peermanager.cpp

src/avalanche/processor.cpp

src/avalanche/test/init_tests.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/processor_tests.cpp

src/init.cpp

test/functional/abc_p2p_avalanche_proof_voting.py

test/functional/abc_p2p_getavaaddr.py

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_getavalancheinfo.py

[avalanche] Deprecate the -enableavalancheproofreplacement flag
ClosedPublic
Actions

Revision Contents
Changeset List