Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an intended replacement for `ArgsManager.GetDataDirPath(net_identifier)`
ClosedPublic
Actions

Authored by PiRK on Sep 12 2022, 08:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbb16bfa11be2: Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an…

Summary

This is a backport of core#21850 [2/6]
https://github.com/bitcoin/bitcoin/pull/21850/commits/0f53df47d5b8319fc71f3b87c15a115ff797fb50

Depends on D11952

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 12 2022, 08:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 08:57

PiRK requested review of this revision.Sep 12 2022, 08:57

teamcity edited the summary of this revision. (Show Details)Sep 12 2022, 08:57

PiRK added a child revision: D11954: scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager.GetDataDirBase()` in tests.Sep 12 2022, 09:00

Harbormaster completed remote builds in B19989: Diff 34911.Sep 12 2022, 09:33

Fabien accepted this revision.Sep 12 2022, 13:41

This revision is now accepted and ready to land.Sep 12 2022, 13:41

Closed by commit rABCbb16bfa11be2: Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an… (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhySep 12 2022, 15:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbb16bfa11be2: Add `ArgsManager.GetDataDirBase()` and `ArgsManager.GetDataDirNet()` as an….

Revision Contents
Changeset List

Path

Size

src/

util/

system.h

20 lines

system.cpp

9 lines

Diff 34921

View Options

src/util/system.h