Paths

Table of Contentst

Differential D11954

scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager.GetDataDirBase()` in tests
ClosedPublic
Actions

Authored by PiRK on Sep 12 2022, 09:00.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC77c979d1cd13: scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager.

Summary

-BEGIN VERIFY SCRIPT-
git ls-files src/test/*_tests.cpp src/test/util/setup_common.cpp | xargs sed -i 's/.GetDataDirPath()/.GetDataDirBase()/g';
-END VERIFY SCRIPT-

This is a backport of core#21850 [3/6]
https://github.com/bitcoin/bitcoin/pull/21850/commits/4d8189f62076d47be182e709857774bc3921b334

Depends on D11953

Note: this obviously changes the directory where the dabase is written, it would have made more sense to use GetDataDirNet. But the test does not seem to care where the database is stored precisely.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 12 2022, 09:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 09:00

PiRK requested review of this revision.Sep 12 2022, 09:00

teamcity edited the summary of this revision. (Show Details)Sep 12 2022, 09:00

PiRK edited the summary of this revision. (Show Details)Sep 12 2022, 09:00

PiRK added a child revision: D11955: Make ArgsManager.GetDataDirPath private and drop needless suffix.Sep 12 2022, 09:01

Harbormaster completed remote builds in B19990: Diff 34912.Sep 12 2022, 09:44

Fabien accepted this revision.Sep 12 2022, 13:43

This revision is now accepted and ready to land.Sep 12 2022, 13:43

Closed by commit rABC77c979d1cd13: scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager. (authored by PiRK). · Explain WhySep 12 2022, 15:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC77c979d1cd13: scripted-diff: Change ArgsManager.GetDataDirPath() to `ArgsManager..

Revision Contents
Changeset List

Path

Size

src/

test/

dbwrapper_tests.cpp

18 lines

denialofservice_tests.cpp

4 lines

flatfile_tests.cpp

8 lines

2 lines

settings_tests.cpp

2 lines

util/

setup_common.cpp

2 lines

20 lines

Diff 34920

src/test/dbwrapper_tests.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

src/test/flatfile_tests.cpp

Loading...

src/test/fs_tests.cpp

Loading...

src/test/settings_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/test/util_tests.cpp

Loading...