Page MenuHomePhabricator
Differential D11980

Improve TransactionErrorString messages.
AbandonedPublic
Actions

Authored by PiRK on Sep 14 2022, 09:01.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This is a backport of core#18027 [1/4]
https://github.com/bitcoin/bitcoin/pull/18027/commits/9e7b23b73387600d175aff8bd5e6624dd51f86e7

Note: the test was intentionnaly skipped in D8104. It does not work with Bitcoin ABC (error message: TX decode failed CDataStream::read(): end of data: iostream error (-22)

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 14 2022, 09:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2022, 09:01
PiRK requested review of this revision.Sep 14 2022, 09:01
teamcity edited the summary of this revision. (Show Details)Sep 14 2022, 09:01
PiRK added a child revision: D11981: FillPSBT: report number of inputs signed (or would sign).Sep 14 2022, 09:04
Harbormaster completed remote builds in B20026: Diff 34963.Sep 14 2022, 09:18
Fabien added a subscriber: Fabien.Sep 15 2022, 08:57

And what about the other error messages ?

PiRK added a comment.Sep 15 2022, 13:17

I can try to figure out a few tests to trigger these errors, but it is going to take some time getting more familiar with PSBTs.

PiRK planned changes to this revision.Sep 15 2022, 13:17
Fabien added a comment.Sep 15 2022, 13:19

It's not PSBT only, it's a generic transaction error. Also you need to be familiar with code you are backporting changes into.

PiRK abandoned this revision.Sep 20 2022, 07:48

I'm abandoning this stack because it is a minor dependency for D11974, and it is easy to work around the dependency. It turns out to be more work than initially expected, and the impact is minor.

Revision Contents
Changeset List

PathSize
src/
util/
6 lines

Diff 34963

View Options

src/util/error.cpp

Loading...