Page MenuHomePhabricator
Differential D12001

[avalanche] Let isfinaltransaction raise an error when the transaction is not found
ClosedPublic
Actions

Authored by Fabien on Sep 17 2022, 07:49.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCdd66085172a8: [avalanche] Let isfinaltransaction raise an error when the transaction is not…
Summary

This makes it easier to guide the user through the reason why the transaction is marked as non final, and hints on how to let the node find the transaction. The error messages are shamelessly copied from getrawtransaction which has the same behavior.

Depends on D12002.

Test Plan
./test/functional/test_runner.py abc_rpc_isfinal

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 17 2022, 07:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2022, 07:49
Fabien requested review of this revision.Sep 17 2022, 07:49
Harbormaster completed remote builds in B20057: Diff 35000.Sep 17 2022, 08:11
Fabien updated this revision to Diff 35004.Sep 19 2022, 16:06

Add a deprecatedrpc option for better compatibility with 0.26.1

Fabien edited the summary of this revision. (Show Details)Sep 19 2022, 16:07
Fabien added a parent revision: D12002: Cleanup the deprecated RPC fields.
Harbormaster completed remote builds in B20060: Diff 35004.Sep 19 2022, 16:24
sdulfari accepted this revision.Sep 19 2022, 17:58
This revision is now accepted and ready to land.Sep 19 2022, 17:58
Fabien planned changes to this revision.Sep 19 2022, 18:04
Fabien updated this revision to Diff 35009.Sep 19 2022, 19:28

Raise an error when the quorum is not ready

This revision is now accepted and ready to land.Sep 19 2022, 19:28
Harbormaster completed remote builds in B20065: Diff 35009.Sep 19 2022, 19:39
sdulfari requested changes to this revision.Sep 19 2022, 20:08
sdulfari added inline comments.
test/functional/rpc_deprecated.py
82 ↗(On Diff #35009)

cleanup?

This revision now requires changes to proceed.Sep 19 2022, 20:08
Fabien added inline comments.Sep 20 2022, 08:20
test/functional/rpc_deprecated.py
82 ↗(On Diff #35009)

woups, good catch

Fabien updated this revision to Diff 35018.Sep 20 2022, 08:21

Rebase, cleanup debug prints

Harbormaster completed remote builds in B20073: Diff 35018.Sep 20 2022, 09:05
sdulfari accepted this revision.Sep 20 2022, 16:36
This revision is now accepted and ready to land.Sep 20 2022, 16:36
Closed by commit rABCdd66085172a8: [avalanche] Let isfinaltransaction raise an error when the transaction is not… (authored by Fabien). · Explain WhySep 20 2022, 19:08
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdd66085172a8: [avalanche] Let isfinaltransaction raise an error when the transaction is not….

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
46 lines
test/
functional/
102 lines
69 lines

Diff 35051

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_isfinal.py

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...