Page MenuHomePhabricator
Differential D12005

[cashtab-components] Running npm upgrade
ClosedPublic
Actions

Authored by bytesofman on Sep 19 2022, 18:01.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCffede807dc64: [cashtab-components] Running npm upgrade
Summary

T2678

Depends on D12004

Run npm upgrade to get ejs > 3.1.7

Test Plan

npm run build and no errors
npm run storybook , starts up, buttons interact with extension

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 19 2022, 18:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2022, 18:01
bytesofman requested review of this revision.Sep 19 2022, 18:01
Harbormaster completed remote builds in B20063: Diff 35007.Sep 19 2022, 18:03
bytesofman added a child revision: D12006: [cashtab-components] upgrading jest.Sep 19 2022, 18:18
emack added a subscriber: emack.Sep 20 2022, 13:37

run build and run storybook tested all ok, however I noticed in package-lock.json the npm upgrade picked up 3.1.8 for ejs, not 3.1.7. Any issues with this versioning?

bytesofman added a comment.Sep 20 2022, 14:24
In D12005#268615, @emack wrote:

run build and run storybook tested all ok, however I noticed in package-lock.json the npm upgrade picked up 3.1.8 for ejs, not 3.1.7. Any issues with this versioning?

Any version 3.1.7 or greater resolves the issue, so 3.1.8 is fine

emack accepted this revision.Sep 20 2022, 14:32
This revision is now accepted and ready to land.Sep 20 2022, 14:32
Closed by commit rABCffede807dc64: [cashtab-components] Running npm upgrade (authored by bytesofman). · Explain WhySep 20 2022, 21:46
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCffede807dc64: [cashtab-components] Running npm upgrade.

Revision Contents
Changeset List

PathSize
web/
cashtab-components/
8483 lines

Diff 35058

View Options

web/cashtab-components/package-lock.json

Loading...