Page MenuHomePhabricator

[Cashtab] Running npm upgrade
ClosedPublic

Authored by bytesofman on Sep 19 2022, 22:45.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC87089dee030d: [Cashtab] Running npm upgrade
Summary

T2678

Running npm upgrade to update peer dependencies

The upgraded eslint caused npm run build to fail due to some lint errors. These are also corrected.

Test Plan

npm run build make sure it still builds
npm start and make sure the app is working ok

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-pseudo-class-any-link@7.1.6',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-selector-not@6.0.1',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated svgo@1.3.2: This SVGO version is no longer supported. Upgrade to v2.x.x.
npm WARN deprecated axios@0.19.2: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
npm WARN deprecated ts-custom-error@2.2.2: npm package tarball contains useless codeclimate-reporter binary, please update to version 3.1.1. See https://github.com/adriengibrat/ts-custom-error/issues/32

> cashtab@1.0.0 prepare
> cd ../.. && husky install web/cashtab/.husky

husky - Git hooks installed

added 1831 packages, and audited 1832 packages in 30s

233 packages are looking for funding
  run `npm fund` for details

13 vulnerabilities (5 moderate, 8 high)

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 7.7.6 -> 8.19.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
npm notice Run `npm install -g npm@8.19.2` to update!
npm notice 

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Common/QRCode.js
  Line 185:17:  Unknown property 'text' found  react/no-unknown-property

src/components/Send/SendToken.js
  Line 535:61:  Unknown property 'heigh' found  react/no-unknown-property
  Line 551:53:  Unknown property 'heigh' found  react/no-unknown-property

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Fixing build errors caused by upgrading eslint

This revision is now accepted and ready to land.Sep 20 2022, 14:15
This revision was automatically updated to reflect the committed changes.