Page MenuHomePhabricator
Differential D12031

Replace Gluon activation time with the actual block height
ClosedPublic
Actions

Authored by Fabien on Sep 22 2022, 13:56.

Details

Reviewers
PiRK
sdulfari
Group Reviewers
Restricted Project
Commits
rABC842acd1ef19c: Replace Gluon activation time with the actual block height
Summary

Gluon upgrade activated on may 2022, let's clean up the activation tests and set activation based on block height rather than mtp.

Test Plan
ninja all check-upgrade-activated-extended

Run IBD on mainnet and testnet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 22 2022, 13:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2022, 13:56
Fabien requested review of this revision.Sep 22 2022, 13:56
Fabien planned changes to this revision.Sep 22 2022, 13:56

Waiting for IBD

Fabien added a comment.Sep 22 2022, 13:56

@bot build-ibd

teamcity awarded a token.Sep 22 2022, 13:56
Harbormaster completed remote builds in B20123: Diff 35106.Sep 22 2022, 14:11
Fabien updated this revision to Diff 35120.Sep 22 2022, 18:57

Rebase, IBD completed

Harbormaster completed remote builds in B20134: Diff 35120.Sep 22 2022, 19:12
Fabien added a child revision: D12037: Run with wellington activated in the tests.Sep 22 2022, 19:41
PiRK accepted this revision.Sep 23 2022, 11:59
This revision is now accepted and ready to land.Sep 23 2022, 11:59
sdulfari requested changes to this revision.Sep 23 2022, 15:49
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/test/activation_tests.cpp
53 ↗(On Diff #35120)

Why not replace with jefferson upgrade?

test/functional/abc_feature_minerfund.py
64 ↗(On Diff #35120)

update comment

70 ↗(On Diff #35120)

Isn't this part redundant?

This revision now requires changes to proceed.Sep 23 2022, 15:49
Fabien added inline comments.Sep 23 2022, 15:58
src/test/activation_tests.cpp
53 ↗(On Diff #35120)

See D12037

test/functional/abc_feature_minerfund.py
70 ↗(On Diff #35120)

yes it is

Fabien updated this revision to Diff 35158.Sep 23 2022, 16:02

Feedback

Harbormaster completed remote builds in B20154: Diff 35158.Sep 23 2022, 16:23
sdulfari accepted this revision.Sep 23 2022, 17:20
This revision is now accepted and ready to land.Sep 23 2022, 17:20
Closed by commit rABC842acd1ef19c: Replace Gluon activation time with the actual block height (authored by Fabien). · Explain WhySep 25 2022, 10:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC842acd1ef19c: Replace Gluon activation time with the actual block height.

Revision Contents
Changeset List

PathSize
src/
6 lines
consensus/
7 lines
4 lines
2 lines
test/
5 lines
28 lines
test/
functional/
41 lines
89 lines
test_framework/
15 lines
lint/
2 lines

Diff 35182

View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

test/functional/abc_feature_minerfund.py

Loading...
View Options

test/functional/abc_mining_basic.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/lint/check-doc.py

Loading...