Page MenuHomePhabricator

Replace Gluon activation time with the actual block height
ClosedPublic

Authored by Fabien on Sep 22 2022, 13:56.

Details

Summary

Gluon upgrade activated on may 2022, let's clean up the activation tests and set activation based on block height rather than mtp.

Test Plan
ninja all check-upgrade-activated-extended

Run IBD on mainnet and testnet

Event Timeline

Fabien requested review of this revision.Sep 22 2022, 13:56
Fabien planned changes to this revision.Sep 22 2022, 13:56

Waiting for IBD

This revision is now accepted and ready to land.Sep 23 2022, 11:59
sdulfari requested changes to this revision.Sep 23 2022, 15:49
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/test/activation_tests.cpp
53 ↗(On Diff #35120)

Why not replace with jefferson upgrade?

test/functional/abc_feature_minerfund.py
64 ↗(On Diff #35120)

update comment

70 ↗(On Diff #35120)

Isn't this part redundant?

This revision now requires changes to proceed.Sep 23 2022, 15:49
src/test/activation_tests.cpp
53 ↗(On Diff #35120)

See D12037

test/functional/abc_feature_minerfund.py
70 ↗(On Diff #35120)

yes it is

This revision is now accepted and ready to land.Sep 23 2022, 17:20