refactor: Replace magic number with named constant
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 12:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8427a837e4d1: refactor: Replace magic number with named constant

Summary

This is a backport of core#18077 [2/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/28e2961fd6a2a9101fc08fb748430989291aaf7e

Depends on D12069

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20195
Build 40075: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40074: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 27 2022, 12:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 12:45

PiRK requested review of this revision.Sep 27 2022, 12:45

teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 12:45

PiRK added a child revision: D12071: net: Add flags for port mapping protocols.Sep 27 2022, 12:55

PiRK added a child revision: D12072: net: Keep trying to use UPnP when -upnp=1.Sep 27 2022, 12:59

PiRK removed a child revision: D12071: net: Add flags for port mapping protocols.Sep 27 2022, 12:59

Harbormaster completed remote builds in B20195: Diff 35209.Sep 27 2022, 13:07

Fabien accepted this revision.Sep 27 2022, 13:37

This revision is now accepted and ready to land.Sep 27 2022, 13:37

Closed by commit rABC8427a837e4d1: refactor: Replace magic number with named constant (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhySep 28 2022, 06:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC8427a837e4d1: refactor: Replace magic number with named constant.

Revision Contents
Changeset List

Path

Size

src/

mapport.cpp

6 lines

Diff 35209

View Options

refactor: Replace magic number with named constantClosedPublicActions