gui: Apply port mapping changes on dialog exit
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 13:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCdad3520ac7b1: gui: Apply port mapping changes on dialog exit

Summary

This commit does not change behavior. It is a prerequisite for NAT-PMP
support adding.

This is a backport of core#18077 [6/13]
https://github.com/bitcoin/bitcoin/pull/18077/commits/58e8364dcdc4e57b0caac09f8402e6535301de9b

Depends on D12073

Test Plan

ninja all check-all

Run src/qt/bitcoin-qt, open the Options menu, go to Network tab, check"Map port using UPnP".
Restart src/qt/bitcoin-qt and check that the settings are persistent.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18077

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20203
Build 40091: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40090: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 27 2022, 13:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 13:01

PiRK requested review of this revision.Sep 27 2022, 13:01

teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 13:01

PiRK edited the test plan for this revision. (Show Details)Sep 27 2022, 13:05

Harbormaster completed remote builds in B20199: Diff 35213.Sep 27 2022, 13:21

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[342/520] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[343/520] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[344/520] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[345/520] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[346/520] Linking C static library src/secp256k1/libsecp256k1.a
[347/520] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[348/520] Linking CXX static library src/libbitcoinconsensus.a
[349/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[350/520] Linking CXX static library src/libscript.a
[351/520] Linking C executable src/secp256k1/internal-bench
[352/520] Linking C executable src/secp256k1/sign-bench
[353/520] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[354/520] Linking C executable src/secp256k1/verify-bench
[355/520] Linking CXX static library src/libcommon.a
[356/520] Linking C executable src/secp256k1/recover-bench
[357/520] Linking CXX shared library src/libbitcoinconsensus.so.0.26.3
[358/520] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[359/520] Linking CXX executable src/bitcoin-cli
[360/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[361/520] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[362/520] Linking CXX executable src/bitcoin-tx
[363/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[364/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[365/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[366/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[367/520] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[368/520] Linking C executable src/secp256k1/ecmult-bench
[369/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[370/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[371/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[372/520] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[373/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[374/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[375/520] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[376/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[377/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[378/520] Linking CXX static library src/zmq/libzmq.a
[379/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[381/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[382/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[383/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[384/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[385/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[386/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[387/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[388/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[389/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[391/520] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[392/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[393/520] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[394/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[395/520] Linking CXX static library src/wallet/libwallet.a
[396/520] Linking CXX static library src/wallet/libwallet-tool.a
[397/520] Linking CXX executable src/bitcoin-wallet
[398/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[399/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1