Paths

Table of Contentst

Differential D12166

[Cashtab] Fix reply button not showing
ClosedPublic
Actions

Authored by kieran709 on Oct 6 2022, 15:38.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCdc95242fb70b: [Cashtab] Fix reply button not showing

Summary

Related to T2712. Fixed issue with reply button not showing up, default behavior is now to show reply button on any OPReturnMsg tx.

Test Plan

cd web/cashtab && npm start
Ensure there are msg txs in recent TxHistory
Observe that the reply button is present on all msg txs
Navigate to settings page
Turn on hideMessagesFromUnknownSenders
navigate back to Home
Observe that the reply button is present on all msg txs.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

reply-button-not-appearing

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20384
Build 40441: Build Diff	cashtab-tests
Build 40440: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 6 2022, 15:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2022, 15:38

kieran709 requested review of this revision.Oct 6 2022, 15:38

Harbormaster completed remote builds in B20384: Diff 35499.Oct 6 2022, 15:41

bytesofman requested changes to this revision.Oct 6 2022, 15:55

bytesofman added inline comments.

web/cashtab/src/components/Home/Tx.js
420	useful for dev but it's gotta go!
963	this should still be `data.parsed.replyAddress`; in this case, the reply link does not work

This revision now requires changes to proceed.Oct 6 2022, 15:55

Responding to review feedback

Harbormaster completed remote builds in B20387: Diff 35502.Oct 6 2022, 16:20

bytesofman accepted this revision.Oct 6 2022, 16:30

This revision is now accepted and ready to land.Oct 6 2022, 16:30

Closed by commit rABCdc95242fb70b: [Cashtab] Fix reply button not showing (authored by kieran709). · Explain WhyOct 6 2022, 16:41

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCdc95242fb70b: [Cashtab] Fix reply button not showing.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Home/

24 lines

Diff 35499

web/cashtab/src/components/Home/Tx.js

Loading...