Page MenuHomePhabricator

[Cashtab] Fix reply button not showing
ClosedPublic

Authored by kieran709 on Oct 6 2022, 15:38.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCdc95242fb70b: [Cashtab] Fix reply button not showing
Summary

Related to T2712. Fixed issue with reply button not showing up, default behavior is now to show reply button on any OPReturnMsg tx.

Test Plan

cd web/cashtab && npm start
Ensure there are msg txs in recent TxHistory
Observe that the reply button is present on all msg txs
Navigate to settings page
Turn on hideMessagesFromUnknownSenders
navigate back to Home
Observe that the reply button is present on all msg txs.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
reply-button-not-appearing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20387
Build 40447: Build Diffcashtab-tests
Build 40446: arc lint + arc unit

Event Timeline

bytesofman requested changes to this revision.Oct 6 2022, 15:55
bytesofman added inline comments.
web/cashtab/src/components/Home/Tx.js
420 ↗(On Diff #35499)

useful for dev but it's gotta go!

963 ↗(On Diff #35499)

this should still be data.parsed.replyAddress; in this case, the reply link does not work

This revision now requires changes to proceed.Oct 6 2022, 15:55

Responding to review feedback

This revision is now accepted and ready to land.Oct 6 2022, 16:30
This revision was automatically updated to reflect the committed changes.