[bench] Benchmark CTxMemPool::check()
ClosedPublic
Actions

Authored by PiRK on Oct 7 2022, 09:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8a5d04de8890: [bench] Benchmark CTxMemPool::check()

Summary

Test Plan

ninja bench-bitcoin

ns/op	op/s	err%	total	benchmark
172,478,220.00	5.80	0.1%	1.90	`ComplexMemPool`
...	...	...	...	...
8.07	123,977,164.61	0.0%	0.00	`MempoolCheck`

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20392
Build 40457: Build Diff	lint-circular-dependencies · build-debug · build-diff · build-without-wallet · build-clang-tidy · build-bench · build-clang
Build 40456: arc lint + arc unit

PiRK created this revision.Oct 7 2022, 09:13

PiRK requested review of this revision.Oct 7 2022, 09:13

PiRK edited the test plan for this revision. (Show Details)Oct 7 2022, 09:14

Fabien accepted this revision.Oct 7 2022, 09:48

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/bench/mempool_stress.cpp
96	That's unused ?

This revision is now accepted and ready to land.Oct 7 2022, 09:48

PiRK added inline comments.Oct 7 2022, 13:37

src/bench/mempool_stress.cpp
96	You are right. I checked other benchmarks, and it seems like a common pattern to create an unused TestingSetup, so maybe there is some cleanup to do.