Reject invalid coin height and output index when loading assumeutxo
ClosedPublic
Actions

Authored by PiRK on Oct 7 2022, 16:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC936b62d8052c: Reject invalid coin height and output index when loading assumeutxo

Summary

This is a backport of core#22146

We can bypassing the temporary ubsan suppressions (core#22202).
The casting to uint32_t is necessary to avoid a -Wsign-compare warning. A block height can not be negative.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2022, 16:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 16:24

PiRK requested review of this revision.Oct 7 2022, 16:24

teamcity edited the summary of this revision. (Show Details)Oct 7 2022, 16:24

Harbormaster completed remote builds in B20403: Diff 35530.Oct 7 2022, 16:37

Fabien accepted this revision.Oct 7 2022, 16:39

This revision is now accepted and ready to land.Oct 7 2022, 16:39

Closed by commit rABC936b62d8052c: Reject invalid coin height and output index when loading assumeutxo (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyOct 10 2022, 08:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC936b62d8052c: Reject invalid coin height and output index when loading assumeutxo.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

9 lines

Diff 35545

View Options

Reject invalid coin height and output index when loading assumeutxoClosedPublicActions