[Cashtab] Tx History should immediately update to include newly added contacts
ClosedPublic
Actions

Authored by kieran709 on Oct 7 2022, 20:19.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC47626f928b9e: [Cashtab] Tx History should immediately update to include newly added contacts

Summary

Related to T2724. Changed logic in updateContactListInLocalForage to setContactList(contactListArray), leveraging Context to make the new contactList immediately available to the Tx component. Renamed updateContactListInLocalForage to updateContactList.

Test Plan

cd web/cashtab && npm start
from TxHistory, expand a Tx from a non-contact
click the Add To Contacts button
navigate back to TxHistory
observe that 'from newContact' appears on Txs from the new contact

navigate to the configure screen
delete the new contact
navigate back to TxHistory
observe that 'from newContact' no longer appears on Txs from the (former) new contact

grep -r 'updateContactListInLocalForage' src/ should return no results.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Oct 7 2022, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2022, 20:19

kieran709 requested review of this revision.Oct 7 2022, 20:19

Harbormaster completed remote builds in B20404: Diff 35531.Oct 7 2022, 20:25

bytesofman requested changes to this revision.Oct 7 2022, 21:21

bytesofman added inline comments.

web/cashtab/src/hooks/useWallet.js
296 ↗	(On Diff #35531)	rename this function to convey the change in behavior I think just `updateContactList` is good now, since it's updating it in 100% of places where it's kept