Related to T2724. Changed logic in updateContactListInLocalForage to setContactList(contactListArray), leveraging Context to make the new contactList immediately available to the Tx component. Renamed updateContactListInLocalForage to updateContactList.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC47626f928b9e: [Cashtab] Tx History should immediately update to include newly added contacts
cd web/cashtab && npm start
from TxHistory, expand a Tx from a non-contact
click the Add To Contacts button
navigate back to TxHistory
observe that 'from newContact' appears on Txs from the new contact
navigate to the configure screen
delete the new contact
navigate back to TxHistory
observe that 'from newContact' no longer appears on Txs from the (former) new contact
grep -r 'updateContactListInLocalForage' src/ should return no results.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- immediately-show-added-contact-txHistory
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20404 Build 40481: Build Diff cashtab-tests Build 40480: arc lint + arc unit
Event Timeline
| web/cashtab/src/hooks/useWallet.js | ||
|---|---|---|
| 296 | rename this function to convey the change in behavior I think just updateContactList is good now, since it's updating it in 100% of places where it's kept | |