Differential D12225

[refactor] versionbits: make VersionBitsCache a full class
ClosedPublic
Actions

Authored by PiRK on Oct 12 2022, 15:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd41722812a7c: [refactor] versionbits: make VersionBitsCache a full class

Summary

Moves the VersionBits* functions to be methods of the cache class,
and makes the cache and its lock private to the class.

This is a partial backport of core#19438
https://github.com/bitcoin/bitcoin/pull/19438/commits/0cfd6c6a8f929d5567ac41f95c21548f115efee5

Depends on D12224

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20469
Build 40610: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40609: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 12 2022, 15:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 15:05

PiRK requested review of this revision.Oct 12 2022, 15:05

teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 15:05

PiRK added a child revision: D12226: [refactor] Move ComputeBlockVersion into VersionBitsCache.Oct 12 2022, 15:11

Harbormaster completed remote builds in B20469: Diff 35622.Oct 12 2022, 15:20

Fabien accepted this revision.Oct 12 2022, 15:58

This revision is now accepted and ready to land.Oct 12 2022, 15:58

Closed by commit rABCd41722812a7c: [refactor] versionbits: make VersionBitsCache a full class (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyOct 13 2022, 09:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd41722812a7c: [refactor] versionbits: make VersionBitsCache a full class.

Revision Contents
Changeset List

Path

Size

src/

deploymentstatus.h

2 lines

rpc/

blockchain.cpp

12 lines

test/

versionbits_tests.cpp

6 lines

validation.cpp

7 lines

versionbits.h

58 lines

versionbits.cpp

36 lines

Diff 35622

View Options

src/deploymentstatus.h

View Options

src/rpc/blockchain.cpp

View Options

src/test/versionbits_tests.cpp

View Options

src/validation.cpp

View Options

src/versionbits.h

View Options

[refactor] versionbits: make VersionBitsCache a full classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35622

src/deploymentstatus.h

src/rpc/blockchain.cpp

src/test/versionbits_tests.cpp

src/validation.cpp

src/versionbits.h

src/versionbits.cpp

[refactor] versionbits: make VersionBitsCache a full class
ClosedPublic
Actions

Revision Contents
Changeset List