Differential D12227

Replace RecursiveMutex m_cs_chainstate with Mutex, and rename it
ClosedPublic
Actions

Authored by Fabien on Oct 12 2022, 15:17.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5c662d2831c2: Replace RecursiveMutex m_cs_chainstate with Mutex, and rename it

Summary

So apparently there is no recursion involved, so the m_cs_chainstate can be a non-recursive mutex.

Backport of core#24103.
Backport of core#24235.

Test Plan

With Debug and Clang:

ninja all check

Run the TSAN build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2022, 15:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 15:17

Fabien requested review of this revision.Oct 12 2022, 15:17

teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 15:17

Harbormaster completed remote builds in B20472: Diff 35625.Oct 12 2022, 15:44

PiRK accepted this revision.Oct 12 2022, 16:20

This revision is now accepted and ready to land.Oct 12 2022, 16:20

Closed by commit rABC5c662d2831c2: Replace RecursiveMutex m_cs_chainstate with Mutex, and rename it (authored by w0xlt <94266259+w0xlt@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 12 2022, 18:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5c662d2831c2: Replace RecursiveMutex m_cs_chainstate with Mutex, and rename it.

PiRK mentioned this in D12485: Move AcceptBlockHeader to ChainstateManager.Nov 14 2022, 15:17

PiRK mentioned this in rABCefb457b0ee6e: Move AcceptBlockHeader to ChainstateManager.Nov 16 2022, 13:59

Revision Contents
Changeset List

Path

Size

src/

validation.h

23 lines

validation.cpp

24 lines

Diff 35629

View Options

src/validation.h