Differential D12230

refactor: no mempool arg to GetCoinsCacheSizeState
ClosedPublic
Actions

Authored by Fabien on Oct 12 2022, 19:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCaa9156b7ef93: refactor: no mempool arg to GetCoinsCacheSizeState

Summary

Unnecessary argument since we can make use of this->m_mempool

Partial backport of core#22415:
https://github.com/bitcoin/bitcoin/pull/22415/commits/4abf0779d6594e97222279110c328b75b5f3db7b#

Depends on D12229.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 12 2022, 19:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2022, 19:31

Fabien requested review of this revision.Oct 12 2022, 19:31

teamcity edited the summary of this revision. (Show Details)Oct 12 2022, 19:32

Fabien added a child revision: D12231: refactor: move UpdateTip into CChainState.Oct 12 2022, 19:32

Harbormaster completed remote builds in B20475: Diff 35631.Oct 12 2022, 19:53

PiRK accepted this revision.Oct 13 2022, 05:30

This revision is now accepted and ready to land.Oct 13 2022, 05:30

Closed by commit rABCaa9156b7ef93: refactor: no mempool arg to GetCoinsCacheSizeState (authored by Fabien). · Explain WhyOct 13 2022, 08:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaa9156b7ef93: refactor: no mempool arg to GetCoinsCacheSizeState.

Revision Contents
Changeset List

Path

Size

src/

test/

validation_flush_tests.cpp

43 lines

validation.h

9 lines

validation.cpp

15 lines

Diff 35638

View Options

src/test/validation_flush_tests.cpp

View Options

src/validation.h

View Options

refactor: no mempool arg to GetCoinsCacheSizeStateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35638

src/test/validation_flush_tests.cpp

src/validation.h

src/validation.cpp

refactor: no mempool arg to GetCoinsCacheSizeState
ClosedPublic
Actions

Revision Contents
Changeset List