Page MenuHomePhabricator
Differential D12238

Remove AcceptToMemoryPoolWithTime
ClosedPublic
Actions

Authored by PiRK on Oct 13 2022, 13:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9e6cbdc2c10b: Remove AcceptToMemoryPoolWithTime
Summary

This is a backport of core#23437
https://github.com/bitcoin/bitcoin/pull/23437/commits/9360778d6e12fd16d44b2d9162628e5036e50dad

The fuzzer part of the first commit and the second commit are not applicable, due to missing fuzzer backports.
Depends on D12236

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 13 2022, 13:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2022, 13:59
PiRK requested review of this revision.Oct 13 2022, 13:59
teamcity edited the summary of this revision. (Show Details)Oct 13 2022, 13:59
Harbormaster completed remote builds in B20490: Diff 35660.Oct 13 2022, 14:01
teamcity added a comment.Oct 13 2022, 14:02
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[328/469] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[329/469] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[330/469] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[331/469] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[332/469] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[333/469] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[334/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[335/469] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[336/469] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[337/469] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[338/469] Linking C static library src/secp256k1/libsecp256k1.a
[339/469] Linking CXX static library src/libscript.a
[340/469] Linking CXX static library src/libbitcoinconsensus.a
[341/469] Linking CXX static library src/libcommon.a
[342/469] Linking CXX shared library src/libbitcoinconsensus.so.0.26.4
[343/469] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[344/469] Linking CXX executable src/bitcoin-cli
[345/469] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[346/469] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[347/469] Linking C executable src/secp256k1/recover-bench
[348/469] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[349/469] Linking C executable src/secp256k1/ecmult-bench
[350/469] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[351/469] Linking C executable src/secp256k1/verify-bench
[352/469] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[353/469] Linking C executable src/secp256k1/sign-bench
[354/469] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[355/469] Linking CXX executable src/bitcoin-tx
[356/469] Linking C executable src/secp256k1/internal-bench
[357/469] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[358/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[359/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[360/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[361/469] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[362/469] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[363/469] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[364/469] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[365/469] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[366/469] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[367/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[368/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[369/469] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[370/469] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[371/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[372/469] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[373/469] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[374/469] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[375/469] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[376/469] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[377/469] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[378/469] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In function ‘MempoolAcceptResult AcceptToMemoryPool(const Config&, CTxMemPool&, CChainState&, const CTransactionRef&, int64_t, bool, bool)’:
../../src/validation.cpp:812:25: error: unused variable ‘chainparams’ [-Werror=unused-variable]
  812 |     const CChainParams &chainparams{active_chainstate.m_params};
      |                         ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Oct 13 2022, 14:02
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[355/523] Linking CXX static library src/libscript.a
[356/523] Linking CXX static library src/libbitcoinconsensus.a
[357/523] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[358/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[359/523] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[360/523] Linking CXX shared library src/libbitcoinconsensus.so.0.26.4
[361/523] Linking C executable src/secp256k1/internal-bench
[362/523] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[363/523] Linking CXX executable src/bitcoin-cli
[364/523] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[365/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[366/523] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[367/523] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[368/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[369/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[370/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[371/523] Linking CXX executable src/bitcoin-tx
[372/523] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[373/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[374/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[376/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[377/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[378/523] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In function ‘MempoolAcceptResult AcceptToMemoryPool(const Config&, CTxMemPool&, CChainState&, const CTransactionRef&, int64_t, bool, bool)’:
../../src/validation.cpp:812:25: error: unused variable ‘chainparams’ [-Werror=unused-variable]
  812 |     const CChainParams &chainparams{active_chainstate.m_params};
      |                         ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
[379/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[380/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[381/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[382/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[383/523] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[384/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[385/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[386/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[387/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[388/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[389/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[391/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[392/523] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[393/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[394/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[395/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[396/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[397/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[398/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[399/523] Linking CXX static library src/wallet/libwallet.a
[400/523] Linking CXX static library src/wallet/libwallet-tool.a
[401/523] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Oct 13 2022, 14:02
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[351/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[352/523] Linking C executable src/secp256k1/recover-bench
[353/523] Linking C executable src/secp256k1/verify-bench
[354/523] Linking C executable src/secp256k1/ecmult-bench
[355/523] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[356/523] Linking C executable src/secp256k1/sign-bench
[357/523] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[358/523] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[359/523] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[360/523] Linking C executable src/secp256k1/internal-bench
[361/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[362/523] Linking CXX executable src/bitcoin-cli
[363/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[364/523] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[365/523] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[366/523] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[367/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[368/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[369/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[370/523] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[371/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[372/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[373/523] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[374/523] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[375/523] Linking CXX executable src/bitcoin-tx
[376/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[377/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[378/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[379/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[380/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[381/523] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[383/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[384/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[385/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[386/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[387/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[388/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[389/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[391/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[392/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[393/523] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[394/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[396/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[397/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[398/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[399/523] Linking CXX static library src/wallet/libwallet.a
[400/523] Linking CXX static library src/wallet/libwallet-tool.a
[401/523] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Oct 13 2022, 14:02
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[358/523] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[359/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[360/523] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[361/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[362/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[363/523] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[364/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[365/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[366/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[367/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[368/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[369/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[370/523] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[371/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[372/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[373/523] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[374/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[375/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[376/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[377/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[378/523] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[379/523] Linking CXX executable src/bitcoin-tx
[380/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[381/523] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[382/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[383/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[384/523] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[385/523] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[386/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[387/523] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[388/523] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[389/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[391/523] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[392/523] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_THREAD_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In function ‘MempoolAcceptResult AcceptToMemoryPool(const Config&, CTxMemPool&, CChainState&, const CTransactionRef&, int64_t, bool, bool)’:
../../src/validation.cpp:812:25: error: unused variable ‘chainparams’ [-Werror=unused-variable]
  812 |     const CChainParams &chainparams{active_chainstate.m_params};
      |                         ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
[393/523] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[394/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[395/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[396/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[397/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[398/523] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[399/523] Linking CXX static library src/wallet/libwallet.a
[400/523] Linking CXX static library src/wallet/libwallet-tool.a
[401/523] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Fabien requested changes to this revision.Oct 13 2022, 14:36
Fabien edited the summary of this revision. (Show Details)
Fabien added a subscriber: Fabien.

Back to your queue

This revision now requires changes to proceed.Oct 13 2022, 14:37
PiRK updated this revision to Diff 35661.Oct 13 2022, 15:02

fix -Werror=unused-variable

Harbormaster completed remote builds in B20491: Diff 35661.Oct 13 2022, 15:18
Fabien requested changes to this revision.Oct 13 2022, 15:42
Fabien added inline comments.
src/validation.cpp
5646 ↗(On Diff #35661)

Please update the comments format as the source material does, this will let clang-tidy find discrepancies in named args

This revision now requires changes to proceed.Oct 13 2022, 15:42
PiRK updated this revision to Diff 35666.Oct 13 2022, 15:50

rebase after adding config to doxygen doc in D12235 and update the comments format

Fabien accepted this revision.Oct 13 2022, 15:50
This revision is now accepted and ready to land.Oct 13 2022, 15:50
Harbormaster completed remote builds in B20494: Diff 35666.Oct 13 2022, 16:20
Closed by commit rABC9e6cbdc2c10b: Remove AcceptToMemoryPoolWithTime (authored by lsilva01 <lsilva01@protonmail.com>, committed by PiRK). · Explain WhyOct 13 2022, 16:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9e6cbdc2c10b: Remove AcceptToMemoryPoolWithTime.
PiRK mentioned this in D12213: make CChainState::m_params public.Oct 14 2022, 06:51

Revision Contents
Changeset List

PathSize
src/
5 lines
23 lines
37 lines

Diff 35666

View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...