Differential D12291

[init] Read/decode asmap before constructing addrman
ClosedPublic
Actions

Authored by Fabien on Oct 18 2022, 13:05.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC98906036effb: [init] Read/decode asmap before constructing addrman

Summary

Commit 181a1207 introduced an initialization order bug: CAddrMan's m_asmap must be set before deserializing peers.dat. Restore that ordering.

Note that we didn't introduce the bug (yet), mostly because most of the referenced PR is not relevant for us so it has been purposedly delayed. A note is added to the code so that later backport will not introduce more issues.

Partial backport of core#22791:
https://github.com/bitcoin/bitcoin/pull/22791/commits/50fd77045e2f858a53486b5e02e1798c92ab946c

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 18 2022, 13:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2022, 13:05

Fabien requested review of this revision.Oct 18 2022, 13:05

teamcity edited the summary of this revision. (Show Details)Oct 18 2022, 13:05

Fabien added a child revision: D12292: [net] Remove CConnMan::SetAsmap().Oct 18 2022, 13:06

Harbormaster completed remote builds in B20575: Diff 35790.Oct 18 2022, 13:17

PiRK accepted this revision.Oct 18 2022, 13:38

This revision is now accepted and ready to land.Oct 18 2022, 13:38

Closed by commit rABC98906036effb: [init] Read/decode asmap before constructing addrman (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 18 2022, 20:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC98906036effb: [init] Read/decode asmap before constructing addrman.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

78 lines

Diff 35808

View Options

[init] Read/decode asmap before constructing addrmanClosedPublicActions