Differential D12293

[addrman] Set m_asmap in CAddrMan initializer list
ClosedPublic
Actions

Authored by Fabien on Oct 18 2022, 13:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb525c4ac805b: [addrman] Set m_asmap in CAddrMan initializer list

Summary

This allows us to make it const.

Partial backport of core#22791:
https://github.com/bitcoin/bitcoin/pull/22791/commits/f572f2b2048994b3b50f4cfd5de19e40b1acfb22#diff-b1e19192258d83199d8adaa5ac31f067af98f63554bfdd679bd8e8073815e69d

Depends on D12292.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 18 2022, 13:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2022, 13:06

Fabien requested review of this revision.Oct 18 2022, 13:06

teamcity edited the summary of this revision. (Show Details)Oct 18 2022, 13:06

Fabien added a child revision: D12294: [addrman] Make m_asmap private.Oct 18 2022, 13:07

Harbormaster completed remote builds in B20577: Diff 35792.Oct 18 2022, 13:28

PiRK accepted this revision.Oct 18 2022, 13:48

This revision is now accepted and ready to land.Oct 18 2022, 13:48

Closed by commit rABCb525c4ac805b: [addrman] Set m_asmap in CAddrMan initializer list (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 18 2022, 20:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb525c4ac805b: [addrman] Set m_asmap in CAddrMan initializer list.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

7 lines

bench/

addrman.cpp

13 lines

init.cpp

4 lines

test/

addrman_tests.cpp

18 lines

fuzz/

deserialize.cpp

3 lines

util/

setup_common.cpp

4 lines

Diff 35810

View Options

src/addrman.h

View Options

src/bench/addrman.cpp

View Options

src/init.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/fuzz/deserialize.cpp

View Options

src/test/util/setup_common.cpp

[addrman] Set m_asmap in CAddrMan initializer listClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35810

src/addrman.h

src/bench/addrman.cpp

src/init.cpp

src/test/addrman_tests.cpp

src/test/fuzz/deserialize.cpp

src/test/util/setup_common.cpp

[addrman] Set m_asmap in CAddrMan initializer list
ClosedPublic
Actions

Revision Contents
Changeset List