Differential D12294

[addrman] Make m_asmap private
ClosedPublic
Actions

Authored by Fabien on Oct 18 2022, 13:07.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC9a1305b07178: [addrman] Make m_asmap private

Summary

Add a GetAsmap() getter function that returns a reference to const.

Partial backport of core#22791:
https://github.com/bitcoin/bitcoin/pull/22791/commits/5840476714ffebb2599999c85a23b52ebcff6090

Depends on D12293.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22791_p4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20579
Build 40828: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40827: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 18 2022, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2022, 13:07

Fabien requested review of this revision.Oct 18 2022, 13:07

teamcity edited the summary of this revision. (Show Details)Oct 18 2022, 13:07

Harbormaster completed remote builds in B20579: Diff 35794.Oct 18 2022, 13:39

sdulfari accepted this revision.Oct 18 2022, 17:08

This revision is now accepted and ready to land.Oct 18 2022, 17:08

Closed by commit rABC9a1305b07178: [addrman] Make m_asmap private (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 18 2022, 20:16

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9a1305b07178: [addrman] Make m_asmap private.

Fabien mentioned this in D12302: [addrman] Move peers.dat parsing to init.cpp.Oct 19 2022, 09:03

Fabien mentioned this in rABCf83a3e877e44: [addrman] Move peers.dat parsing to init.cpp.Oct 19 2022, 12:29

Revision Contents
Changeset List

Path

Size

src/

addrman.h

38 lines

net.cpp

12 lines

Diff 35794

View Options

src/addrman.h