Differential D12302

[addrman] Move peers.dat parsing to init.cpp
ClosedPublic
Actions

Authored by Fabien on Oct 19 2022, 09:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf83a3e877e44: [addrman] Move peers.dat parsing to init.cpp

Summary

Backport of core#22697.

Only these commits are interesting:
https://github.com/bitcoin/bitcoin/pull/22697/commits/181a1207ba6bd179d181f3e2534ef8676565ce72
https://github.com/bitcoin/bitcoin/pull/22697/commits/e8e7392311edf44278d76743bebe902d4ac94662

Removing the Clear() method would be interesting but it prevents use from being able to make the CConnman's CAddrMan deterministic and we need this for testing, so we skip that part.

Because we already backported PR22791 (see D12294), no ordering bug is introduced here.

Depends on D12300.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 19 2022, 09:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2022, 09:03

Fabien requested review of this revision.Oct 19 2022, 09:03

teamcity edited the summary of this revision. (Show Details)Oct 19 2022, 09:03

Harbormaster completed remote builds in B20601: Diff 35829.Oct 19 2022, 09:20

Fabien added a child revision: D12304: Remove confusing CAddrDB.Oct 19 2022, 10:03

Looks good. But you backported two commits (https://github.com/bitcoin/bitcoin/pull/22697/commits/e8e7392311edf44278d76743bebe902d4ac94662)

This revision is now accepted and ready to land.Oct 19 2022, 11:26

Fabien edited the summary of this revision. (Show Details)Oct 19 2022, 12:29

Closed by commit rABCf83a3e877e44: [addrman] Move peers.dat parsing to init.cpp (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 19 2022, 12:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf83a3e877e44: [addrman] Move peers.dat parsing to init.cpp.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

19 lines

net.cpp

18 lines

Diff 35841

View Options

src/init.cpp