Deduplicate call to PreChecks in AcceptSingleTransaction
ClosedPublic
Actions

Authored by PiRK on Oct 21 2022, 13:25.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC512168c24f94: Deduplicate call to PreChecks in AcceptSingleTransaction

Summary

I accidentaly duplicated this in D12347, which caused a double count of the number of ancestors.

Test Plan

ninja check-functional-extended

mempool_updatefromblock.py is the test that highlighted the mistake

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20667
Build 40998: Build Diff	lint-circular-dependencies · build-clang-tidy · build-clang · build-without-wallet · build-diff · build-debug
Build 40997: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 21 2022, 13:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2022, 13:25

PiRK requested review of this revision.Oct 21 2022, 13:25

Harbormaster completed remote builds in B20667: Diff 35934.Oct 21 2022, 13:40

Fabien accepted this revision.Oct 21 2022, 14:00

This revision is now accepted and ready to land.Oct 21 2022, 14:00

Closed by commit rABC512168c24f94: Deduplicate call to PreChecks in AcceptSingleTransaction (authored by PiRK). · Explain WhyOct 21 2022, 14:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC512168c24f94: Deduplicate call to PreChecks in AcceptSingleTransaction.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

4 lines

Diff 35934

View Options

Deduplicate call to PreChecks in AcceptSingleTransactionClosedPublicActions